diff options
| author | ivarlovlie <git@ivarlovlie.no> | 2022-11-17 07:46:38 +0100 |
|---|---|---|
| committer | ivarlovlie <git@ivarlovlie.no> | 2022-11-17 07:46:38 +0100 |
| commit | 971a70d15e5531b59afd74556dc50214deeeafe9 (patch) | |
| tree | 67210f7bf53dcbe5b17bf62c7837dca1cd88907c /code/api/src/Endpoints/V1 | |
| parent | 18b8d910b3dfa1e5c2a39b401b007b5e1ab8dea5 (diff) | |
| download | greatoffice-971a70d15e5531b59afd74556dc50214deeeafe9.tar.xz greatoffice-971a70d15e5531b59afd74556dc50214deeeafe9.zip | |
feat: Update known problem model
Diffstat (limited to 'code/api/src/Endpoints/V1')
| -rw-r--r-- | code/api/src/Endpoints/V1/Customers/CreateCustomerRoute.cs | 11 | ||||
| -rw-r--r-- | code/api/src/Endpoints/V1/Projects/CreateProjectRoute.cs | 14 |
2 files changed, 17 insertions, 8 deletions
diff --git a/code/api/src/Endpoints/V1/Customers/CreateCustomerRoute.cs b/code/api/src/Endpoints/V1/Customers/CreateCustomerRoute.cs index eb69f7f..b20b404 100644 --- a/code/api/src/Endpoints/V1/Customers/CreateCustomerRoute.cs +++ b/code/api/src/Endpoints/V1/Customers/CreateCustomerRoute.cs @@ -16,9 +16,14 @@ public class CreateCustomerRoute : RouteBaseAsync.WithRequest<CreateCustomerPayl [HttpPost("~/v{version:apiVersion}/customers/create")] public override async Task<ActionResult> HandleAsync(CreateCustomerPayload request, CancellationToken cancellationToken = default) { - var errors = new Dictionary<string, string>(); - if (request.Name.Trim().IsNullOrEmpty()) errors.Add("name", _localizer["Name is a required field"]); - if (errors.Any()) return KnownProblem(_localizer["Invalid form"], _localizer["One or more fields is invalid"], errors); + var problem = new KnownProblemModel(); + if (request.Name.Trim().IsNullOrEmpty()) problem.AddError("name", _localizer["Name is a required field"]); + if (problem.Errors.Any()) { + problem.Title = _localizer["Invalid form"]; + problem.Subtitle = _localizer["One or more validation errors occured"]; + return KnownProblem(problem); + } + var customer = new Customer(LoggedInUser) { CustomerNumber = request.CustomerNumber, Name = request.Name, diff --git a/code/api/src/Endpoints/V1/Projects/CreateProjectRoute.cs b/code/api/src/Endpoints/V1/Projects/CreateProjectRoute.cs index 5c78e27..04a3a9a 100644 --- a/code/api/src/Endpoints/V1/Projects/CreateProjectRoute.cs +++ b/code/api/src/Endpoints/V1/Projects/CreateProjectRoute.cs @@ -14,10 +14,10 @@ public class CreateProjectRoute : RouteBaseAsync.WithRequest<CreateProjectPayloa [HttpPost("~/v{version:apiVersion}/projects/create")] public override async Task<ActionResult> HandleAsync(CreateProjectPayload request, CancellationToken cancellationToken = default) { - var errors = new Dictionary<string, string>(); + var problem = new KnownProblemModel(); if (request.Name.IsNullOrEmpty()) { - errors.Add("name", _localizer["Name is a required field"]); + problem.AddError("name", _localizer["Name is a required field"]); } var project = new Project(LoggedInUser) { @@ -31,7 +31,7 @@ public class CreateProjectRoute : RouteBaseAsync.WithRequest<CreateProjectPayloa foreach (var customerId in request.CustomerIds) { var customer = _database.Customers.FirstOrDefault(c => c.Id == customerId); if (customer == default) { - errors.Add("customer_" + customerId, _localizer["Customer not found"]); + problem.AddError("customer_" + customerId, _localizer["Customer not found"]); continue; } @@ -41,7 +41,7 @@ public class CreateProjectRoute : RouteBaseAsync.WithRequest<CreateProjectPayloa foreach (var member in request.Members) { var user = _database.Users.FirstOrDefault(c => c.Id == member.UserId); if (user == default) { - errors.Add("members_" + member.UserId, _localizer["User not found"]); + problem.AddError("members_" + member.UserId, _localizer["User not found"]); continue; } @@ -52,7 +52,11 @@ public class CreateProjectRoute : RouteBaseAsync.WithRequest<CreateProjectPayloa }); } - if (errors.Any()) return KnownProblem(_localizer["Invalid form"], _localizer["One or more fields is invalid"], errors); + if (problem.Errors.Any()) { + problem.Title = _localizer["Invalid form"]; + problem.Subtitle = _localizer["One or more validation errors occured"]; + return KnownProblem(problem); + } _database.Projects.Add(project); await _database.SaveChangesAsync(cancellationToken); |
