feat: Specify frontend url as redirect uri for github

2 files changed, 7 insertions, 20 deletions

diff --git a/src/server/Api/Internal/Account/CreateGithubSessionRoute.cs b/src/server/Api/Internal/Account/CreateGithubSessionRoute.cs
index 21cfead..b13cff7 100644
--- a/src/server/Api/Internal/Account/CreateGithubSessionRoute.cs
+++ b/src/server/Api/Internal/Account/CreateGithubSessionRoute.cs
@@ -4,13 +4,19 @@ namespace IOL.BookmarkThing.Server.Api.Internal.Account;
 
 public class CreateGithubSessionRoute : RouteBaseInternalSync.WithoutRequest.WithActionResult
 {
+	private readonly IConfiguration _configuration;
+
+	public CreateGithubSessionRoute(IConfiguration configuration) {
+		_configuration = configuration;
+	}
+
 	[AllowAnonymous]
 	[ApiVersionNeutral]
 	[ApiExplorerSettings(IgnoreApi = true)]
 	[HttpGet("~/v{version:apiVersion}/account/create-github-session")]
 	public override ActionResult Handle() {
 		return Challenge(new AuthenticationProperties {
-								 RedirectUri = "/oauth-cb",
+								 RedirectUri = _configuration.GetValue<string>("FRONTEND_CANONICAL_URL"),
 						 },
 						 GitHubAuthenticationDefaults.AuthenticationScheme);
 	}
diff --git a/src/server/Api/Internal/OAuthCallbackRoute.cs b/src/server/Api/Internal/OAuthCallbackRoute.cs
deleted file mode 100644
index d2823c4..0000000
--- a/src/server/Api/Internal/OAuthCallbackRoute.cs
+++ /dev/null
@@ -1,19 +0,0 @@
-namespace IOL.BookmarkThing.Server.Api.Internal;
-
-public class OAuthCallbackRoute : RouteBaseInternalSync.WithoutRequest.WithActionResult
-{
-	private readonly IConfiguration _configuration;
-
-	public OAuthCallbackRoute(IConfiguration configuration) {
-		_configuration = configuration;
-	}
-
-	[AllowAnonymous]
-	[ApiVersionNeutral]
-	[ApiExplorerSettings(IgnoreApi = true)]
-	[HttpGet("~/oauth-cb")]
-	public override ActionResult Handle() {
-		Console.WriteLine(JsonSerializer.Serialize(HttpContext.User));
-		return Redirect(_configuration.GetValue<string>("FRONTEND_CANONICAL_URL"));
-	}
-}