From f3893d16f31fba52e4df9780c09a0d1c140da102 Mon Sep 17 00:00:00 2001
From: ivar <i@oiee.no>
Date: Sun, 28 Apr 2024 22:32:31 +0200
Subject: Remove smells

---
 src/IOL.VippsEcommerce.Client/Program.cs | 15 +++++++--------
 src/IOL.VippsEcommerce.Tests/Helpers.cs  |  3 +--
 src/IOL.VippsEcommerce/Helpers.cs        | 10 +++++-----
 3 files changed, 13 insertions(+), 15 deletions(-)

(limited to 'src')

diff --git a/src/IOL.VippsEcommerce.Client/Program.cs b/src/IOL.VippsEcommerce.Client/Program.cs
index 9062956..7f76804 100644
--- a/src/IOL.VippsEcommerce.Client/Program.cs
+++ b/src/IOL.VippsEcommerce.Client/Program.cs
@@ -5,16 +5,15 @@ using Microsoft.Extensions.DependencyInjection;
 
 var services = new ServiceCollection();
 services.AddVippsEcommerceService(o => {
-	o.ClientSecret = "asdf";
-	o.ClientId = "asdf";
-	o.ApiUrl = "sadf";
-	o.PrimarySubscriptionKey = "";
-	o.Verify();
+    o.ClientSecret = "asdf";
+    o.ClientId = "asdf";
+    o.ApiUrl = "sadf";
+    o.PrimarySubscriptionKey = "";
+    o.Verify();
 });
 var provider = services.BuildServiceProvider();
 var vippsEcommerceService = provider.GetService<IVippsEcommerceService>();
 if (vippsEcommerceService == default) {
-	return;
+    return;
 }
-
-Console.WriteLine(JsonSerializer.Serialize(vippsEcommerceService.Configuration));
+Console.WriteLine(JsonSerializer.Serialize(vippsEcommerceService.Configuration));
\ No newline at end of file
diff --git a/src/IOL.VippsEcommerce.Tests/Helpers.cs b/src/IOL.VippsEcommerce.Tests/Helpers.cs
index 53dd49b..c5f1fd9 100644
--- a/src/IOL.VippsEcommerce.Tests/Helpers.cs
+++ b/src/IOL.VippsEcommerce.Tests/Helpers.cs
@@ -1,7 +1,6 @@
 using System;
 using IOL.VippsEcommerce.Models;
 using Microsoft.Extensions.DependencyInjection;
-using Xunit.Sdk;
 
 namespace IOL.VippsEcommerce.Tests;
 
@@ -13,7 +12,7 @@ public static class Helpers
 		var provider = services.BuildServiceProvider();
 		var vippsEcommerceService = provider.GetService<IVippsEcommerceService>();
 		if (vippsEcommerceService == default) {
-			throw new NullException(nameof(vippsEcommerceService));
+			throw new NullReferenceException(nameof(vippsEcommerceService));
 		}
 
 		return vippsEcommerceService;
diff --git a/src/IOL.VippsEcommerce/Helpers.cs b/src/IOL.VippsEcommerce/Helpers.cs
index 7e61181..9f30da8 100644
--- a/src/IOL.VippsEcommerce/Helpers.cs
+++ b/src/IOL.VippsEcommerce/Helpers.cs
@@ -16,15 +16,15 @@ internal static class Helpers
 
 	public static bool IsDirectoryWritable(this string dirPath, bool throwIfFails = false) {
 		try {
-			using (var fs = File.Create(Path.Combine(dirPath, Path.GetRandomFileName()),
-										1,
-										FileOptions.DeleteOnClose)
-				  ) { }
+            using var _ = File.Create(Path.Combine(dirPath, Path.GetRandomFileName()),
+                1,
+                FileOptions.DeleteOnClose);
 
 			return true;
 		} catch {
-			if (throwIfFails)
+            if (throwIfFails) {
 				throw;
+            }
 
 			return false;
 		}
-- 
cgit v1.3